Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github action to validate the PR. #39

Open
preetkaran20 opened this issue Jul 5, 2021 · 3 comments
Open

Add a github action to validate the PR. #39

preetkaran20 opened this issue Jul 5, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@preetkaran20
Copy link
Member

preetkaran20 commented Jul 5, 2021

There is currently no Github action that validates the PR. Add the action to validate both javascript/typescript changes (npm run build) and also Lua changes in the PR.

@preetkaran20 preetkaran20 added enhancement New feature or request good first issue Good for newcomers labels Jul 5, 2021
@preetkaran20 preetkaran20 changed the title Adding a github action to validate code changes. Add a github action to validate code changes. Jul 5, 2021
@preetkaran20 preetkaran20 changed the title Add a github action to validate code changes. Add a github action to validate the PR. Jul 5, 2021
@preetkaran20
Copy link
Member Author

Added the PR validation for the javascript/typescript module. Left part is LUA validation.

@lmcdo
Copy link

lmcdo commented Jun 6, 2022

I can help could you provide further requirement details? thanks

@preetkaran20
Copy link
Member Author

preetkaran20 commented Jun 6, 2022

Hi @lmcdo ,

So currently, this project has TypeScript/Javascript as well as Lua file (for openresty) and we are looking for a github action to compile and validate the PR before merging it into master.

Currently the github actions is there at https://github.com/SasanLabs/VulnerableApp-facade/blob/main/.github/workflows/Compile.yml and it is working fine for Typescript/Javascript but we want to include the LUA validator as well. Also I am not sure, if we are running unit tests for Typescript/Javascript as part of the PR build so wanted to validate that as well.

LUA script is present at: https://github.com/SasanLabs/VulnerableApp-facade/tree/main/lua-modules. it is invoked from https://github.com/SasanLabs/VulnerableApp-facade/blob/main/nginx.conf (nginx.conf)

Please let me know, if you need more information.

thanks,
Karan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants