Fill omitted member initializations

* fix minor code defects

Signed-off-by: HyukWoo Park <[email protected]>

src/intl/IntlDateTimeFormat.cpp

@@ -319,6 +319,7 @@ IntlDateTimeFormatObject::IntlDateTimeFormatObject(ExecutionState& state, Object
     , m_calendar(String::emptyString)
     , m_numberingSystem(String::emptyString)
     , m_timeZone(String::emptyString)
+    , m_icuDateFormat(nullptr)
 {
     // Let requestedLocales be ? CanonicalizeLocaleList(locales).
     ValueVector requestedLocales = Intl::canonicalizeLocaleList(state, locales);

src/intl/IntlDisplayNames.cpp

@@ -32,6 +32,12 @@ namespace Escargot {
 
 IntlDisplayNamesObject::IntlDisplayNamesObject(ExecutionState& state, Object* proto, Value locales, Value options)
     : DerivedObject(state, proto)
+    , m_style(nullptr)
+    , m_type(nullptr)
+    , m_fallback(nullptr)
+    , m_locale(nullptr)
+    , m_languageDisplay(nullptr)
+    , m_icuLocaleDisplayNames(nullptr)
 {
 #if defined(ENABLE_RUNTIME_ICU_BINDER)
     UVersionInfo versionArray;

src/intl/IntlListFormat.cpp

@@ -35,6 +35,10 @@ namespace Escargot {
 
 IntlListFormatObject::IntlListFormatObject(ExecutionState& state, Object* proto, Value locales, Value options)
     : DerivedObject(state, proto)
+    , m_locale(nullptr)
+    , m_type(nullptr)
+    , m_style(nullptr)
+    , m_icuListFormatter(nullptr)
 {
     // https://tc39.es/ecma402/#sec-Intl.ListFormat
 #if defined(ENABLE_RUNTIME_ICU_BINDER)

src/intl/IntlLocale.cpp

@@ -202,6 +202,11 @@ IntlLocaleObject::IntlLocaleObject(ExecutionState& state, String* tag, Optional<
 
 IntlLocaleObject::IntlLocaleObject(ExecutionState& state, Object* proto, String* tag, Optional<Object*> options)
     : DerivedObject(state, proto)
+    , m_language(nullptr)
+    , m_script(nullptr)
+    , m_region(nullptr)
+    , m_baseName(nullptr)
+    , m_locale(nullptr)
 {
     // Set tag to ? ApplyOptionsToTag(tag, options).
     Intl::CanonicalizedLangunageTag buildResult = applyOptionsToTag(state, tag, options);

src/intl/IntlPluralRules.cpp

@@ -72,6 +72,11 @@ void* IntlPluralRulesObject::operator new(size_t size)
 
 IntlPluralRulesObject::IntlPluralRulesObject(ExecutionState& state, Object* proto, Value locales, Value options)
     : DerivedObject(state, proto)
+    , m_locale(nullptr)
+    , m_type(nullptr)
+    , m_minimumIntegerDigits(0)
+    , m_minimumFractionDigits(0)
+    , m_maximumFractionDigits(0)
     , m_icuPluralRules(nullptr)
     , m_icuNumberFormat(nullptr)
 {

src/intl/IntlRelativeTimeFormat.cpp

@@ -56,6 +56,12 @@ IntlRelativeTimeFormatObject::IntlRelativeTimeFormatObject(ExecutionState& state
 
 IntlRelativeTimeFormatObject::IntlRelativeTimeFormatObject(ExecutionState& state, Object* proto, Value locales, Value optionsInput)
     : DerivedObject(state, proto)
+    , m_locale(nullptr)
+    , m_dataLocale(nullptr)
+    , m_numberingSystem(nullptr)
+    , m_style(nullptr)
+    , m_numeric(nullptr)
+    , m_icuRelativeDateTimeFormatter(nullptr)
 {
 #if defined(ENABLE_RUNTIME_ICU_BINDER)
     UVersionInfo versionArray;

src/util/Vector.h

@@ -374,16 +374,17 @@ class Vector : public gc {
 
     void shrinkToFit()
     {
+        ASSERT(m_size <= m_capacity);
         if (m_size != m_capacity) {
             if (m_size) {
+                ASSERT(!!m_buffer);
                 T* newBuffer = Allocator().allocate(m_size);
                 VectorCopier<T>::copy(newBuffer, m_buffer, m_size);
 
-                size_t oldC = m_capacity;
-                m_capacity = m_size;
-                if (m_buffer)
-                    Allocator().deallocate(m_buffer, oldC);
+                Allocator().deallocate(m_buffer, m_capacity);
+
                 m_buffer = newBuffer;
+                m_capacity = m_size;
             } else {
                 clear();
             }