-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification on prediction_mask in MoiraiFinetune #29
Comments
Hey, thanks for catching this. I think you're right, it should be |
Hi, it should be |
I think there wouldn't be a difference if the prediction range is already padded? |
Let's say if prediction length is 96 and patch size is 64, the prediction range will be padded to 128 to make sure there are multiple patches. So, the last 2 patches should be masked as True in If we use |
Right... this makes sense. Thanks a lot! |
Hi @gorold. May I clarify the setup of the prediction mask in validation dataset in MoiraiFinetune?
Now
mask_length
is computed as-prediction_length % patch_size
. Shouldn't themask_length
be computed asprediction_length // patch_size
? As the logic here seems to mask the patches in the prediction range.Please correct me if my understanding is incorrect. Look forward to your reply.
The text was updated successfully, but these errors were encountered: