Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to link to hendrikmaus/drafter-installer #32

Open
JelmerD opened this issue Jan 7, 2017 · 3 comments
Open

Suggest to link to hendrikmaus/drafter-installer #32

JelmerD opened this issue Jan 7, 2017 · 3 comments

Comments

@JelmerD
Copy link

JelmerD commented Jan 7, 2017

Drafter doesn't support an easy way to install into a PHP project via composer.

https://github.com/hendrikmaus/drafter-installer gives a useful method to do so.

I suggest to link to this installer in the phpdraft documentation as it works very easily.

Maybe a conversion to build onto the php-drafter is a next step as well? As it seems to be the "recognised" php-drafter wrapper https://github.com/apiaryio/drafter#cli-wrapper and the json output is very straight forward. Only a JSON to HTML conversion is needed then. All the drafter to PHP logic is already done.

@SMillerDev
Copy link
Owner

Kinda hesitant to add this as the main use for this application is as a phar file.
Composer dependency isn't needed, nor should it be used if you just use the phar file.
Might want to add it for development but I personally prefer to use a package manager to install it as that is how the users are expected to install it.

If you send me a PR I'd probably merge it though.

@JelmerD
Copy link
Author

JelmerD commented Jan 10, 2017

I don't have the time to do that at the moment, I'm sorry. But I appreciate your feedback. I suggest to keep this open for somebody else? Your choice 😄

@SMillerDev
Copy link
Owner

I'll keep this open for someone else to pick up. But 1.7 is now able to use the apiary API web service. So there's now less of a need to install drafter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants