Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory path in the CMakeLists.txt #136

Open
sinban04 opened this issue Feb 16, 2017 · 2 comments
Open

Directory path in the CMakeLists.txt #136

sinban04 opened this issue Feb 16, 2017 · 2 comments

Comments

@sinban04
Copy link
Contributor

Currently, we are using the directory path as ${CMAKE_SOURCE_DIR} in the CMakeLists.txt
${CMAKE_SOURCE_DIR} This means the directory path where the first intial cmake file is in.
And we are using the relative path to the ${CMAKE_SOURCE_DIR}.

This could be confusing to get the path, and when doing unit test, the path is mingled.
Therefore, i suggest that we need to use some defined explicit absolute path sth like OPEL_DIR.
And then, we can use relative path to OPEL_DIR, which clarifies the directory path concept.

@RedCarrottt
Copy link
Member

I have a different idea.

Some users would want to build only a part of OPEL platform separately. (i.e. building only appcore-manager)
In this case, ${CMAKE_SOURCE_DIR} can make sense, rather than ${OPEL_DIR}.

@sinban04
Copy link
Contributor Author

Yeah, It could be.
in that case, it's right to use ${CMAKE_SOURCE_DIR}.
I think the idea should be considered and shared in all cmake files.
some code is based on that concept, but some code are not.
(e.g., some directory path is like "../../out/bin")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants