You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we are using the directory path as ${CMAKE_SOURCE_DIR} in the CMakeLists.txt
${CMAKE_SOURCE_DIR} This means the directory path where the first intial cmake file is in.
And we are using the relative path to the ${CMAKE_SOURCE_DIR}.
This could be confusing to get the path, and when doing unit test, the path is mingled.
Therefore, i suggest that we need to use some defined explicit absolute path sth like OPEL_DIR.
And then, we can use relative path to OPEL_DIR, which clarifies the directory path concept.
The text was updated successfully, but these errors were encountered:
Some users would want to build only a part of OPEL platform separately. (i.e. building only appcore-manager)
In this case, ${CMAKE_SOURCE_DIR} can make sense, rather than ${OPEL_DIR}.
Yeah, It could be.
in that case, it's right to use ${CMAKE_SOURCE_DIR}.
I think the idea should be considered and shared in all cmake files.
some code is based on that concept, but some code are not.
(e.g., some directory path is like "../../out/bin")
Currently, we are using the directory path as ${CMAKE_SOURCE_DIR} in the CMakeLists.txt
${CMAKE_SOURCE_DIR} This means the directory path where the first intial cmake file is in.
And we are using the relative path to the ${CMAKE_SOURCE_DIR}.
This could be confusing to get the path, and when doing unit test, the path is mingled.
Therefore, i suggest that we need to use some defined explicit absolute path sth like OPEL_DIR.
And then, we can use relative path to OPEL_DIR, which clarifies the directory path concept.
The text was updated successfully, but these errors were encountered: