-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup_fastf1 + vignette #126
Conversation
Hmm perhaps a more dedicated vignette towards advanced use-cases (the type of analysis you do with the package for example, if you're comfortable sharing that). |
I think I can come up with a set of 'exploratory' analysis type things for some Ergast-derived data. That'd be a after-CRAN job I think. Is there anything extra for this setup_fastf1 vignette that you think should be added? |
…1dataR into setup-fastf1-vignette
No, I think it's pretty thorough |
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 92.33% 91.87% -0.46%
==========================================
Files 18 18
Lines 535 554 +19
==========================================
+ Hits 494 509 +15
- Misses 41 45 +4
|
I think this can be merged now... That was tough to hammer out for all the platforms. |
You likely need to mark a new release in GitHub - this is v1.2.0 |
DRAFT Not to merge yet.
@SCasanova any suggestions for function enhancements or vignette improvements are appreciated.
Would a similar helper function for folks to easily update
fastf1
to the current version be worthwhile?As per #119