Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup_fastf1 + vignette #126

Merged
merged 19 commits into from
Jul 16, 2023
Merged

Conversation

pbulsink
Copy link
Collaborator

DRAFT Not to merge yet.

@SCasanova any suggestions for function enhancements or vignette improvements are appreciated.

Would a similar helper function for folks to easily update fastf1 to the current version be worthwhile?

As per #119

@SCasanova
Copy link
Owner

Hmm perhaps a more dedicated vignette towards advanced use-cases (the type of analysis you do with the package for example, if you're comfortable sharing that).

@pbulsink
Copy link
Collaborator Author

Hmm perhaps a more dedicated vignette towards advanced use-cases (the type of analysis you do with the package for example, if you're comfortable sharing that).

I think I can come up with a set of 'exploratory' analysis type things for some Ergast-derived data. That'd be a after-CRAN job I think. Is there anything extra for this setup_fastf1 vignette that you think should be added?

@SCasanova
Copy link
Owner

No, I think it's pretty thorough

@SCasanova SCasanova added this to the CRAN Release milestone Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #126 (e8087e1) into master (c6fe2b1) will decrease coverage by 0.46%.
The diff coverage is 84.00%.

❗ Current head e8087e1 differs from pull request most recent head e979819. Consider uploading reports for the commit e979819 to get more accurate results

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   92.33%   91.87%   -0.46%     
==========================================
  Files          18       18              
  Lines         535      554      +19     
==========================================
+ Hits          494      509      +15     
- Misses         41       45       +4     
Impacted Files Coverage Δ
R/load_race_session.R 90.32% <ø> (ø)
R/load_schedule.R 100.00% <ø> (ø)
R/load_session_laps.R 97.91% <ø> (ø)
R/utils.R 77.14% <80.95%> (+0.21%) ⬆️
R/load_driver_telemetry.R 88.23% <100.00%> (+0.23%) ⬆️

@pbulsink
Copy link
Collaborator Author

I think this can be merged now... That was tough to hammer out for all the platforms.

@pbulsink pbulsink changed the title [DRAFT] setup_fastf1 + vignette Setup_fastf1 + vignette Jul 16, 2023
@SCasanova SCasanova merged commit 12b8e33 into SCasanova:master Jul 16, 2023
11 of 12 checks passed
@pbulsink
Copy link
Collaborator Author

You likely need to mark a new release in GitHub - this is v1.2.0

@pbulsink pbulsink deleted the setup-fastf1-vignette branch July 16, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants