[FEATURE] initialAdmins in BTP Subaccount #91
Description
Is your feature request related to a problem? Please describe.
The initial problem and possible solutions were started to be discussed internally.
As the BTP provider doesn't support changes on subaccountAdmins on existing resources, once a Subaccount has been created with a certain list of users in subaccountAdmins, in case it changes, it will not only refuse to update the admins, but will as well refuse any other change of other attributes in that resource, which will block any updates on older Subaccounts.
Describe the solution you'd like
By renaming attribute subaccountAdmins with initialAdmins (I assume by deprecating one and introducing the other as a new one), the communication becomes clear that future updates of the Subaccount resource will ignore this attribute. Therefore, it's possible to allow Subaccount to be updated even if the list of admin users don't match with the initial one.
Acceptance Criteria
- new field called
initialAdminsto existingv1alpha1version- make it optional (for the sake of backwards compatibility) but enforce it being set when initally applied (via CRD validation rules)
- make subaccountAdmins optional (make sure this is backwards compatible) and add deprecation note in comments
- adapt in unit and e2e tests to verify new behaviour [think about giving it an upgrade test]
- kubebuilder common expression language: fill only one of the two fields (initial is prefered)
- deprecate old field
- PR for updating community guide
Alternative
Don't manage members at this level at all - the terraform provider seems to have this removed
https://registry.terraform.io/providers/SAP/btp/latest/docs/resources/subaccount