Skip to content

[FEATURE] Add instanceName and bindingName for CloudManagement CRD #73

@sdischer-sap

Description

@sdischer-sap

Is your feature request related to a problem? Please describe.
The Cloudmanagement resource currently uses medatdata.name as a name in BTP.

Since the metadata should be related only to k8s internal aspects thats not a good design choice. It also violates the idea of having everything payload-relevant in the spec.forProvider.
It also not really possible to import a resource without using the same name or letting it change it.

Describe the solution you'd like
It makes sense to follow the same approach as with the ServiceManager kind. It allows to specify an serviceInstanceName as well as a serviceBindingName. Those should be optional. If none is specified I would argue to use a static default value rather then the metadata.name. Same approach is used in the ServiceManager as well, so the implementation can be pretty much copied.

More precise requirements to meet

  • if from a schema endpoint only those two new optional values are added we can create a new v1alpha2 version. A Conversion should be done implicitly in this case
  • the implementation must be backwards compatible, meaning resources created with previous versions must reconcile successfully without doing any changes to resource, that needs to be tested at least manually

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requesthelp wantedExtra attention is needed

Projects

Status

Closed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions