-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Feedback (JSONModel && Promisification) #6
Comments
Hi Timo, thanks a lot for your detailed feedback! We're definitely looking into it. |
Hi @akudev , Thanks for the response. FYI: I've uploaded examples for all suggestions using Northwind Service inside https://github.com/timostark/ui5-typescript-sample. The statically typed JSON model is really super nice to be used honestly :-) Change-detection is now done using decorators. Do you plan to provide decorators from your side? An example would be a decorator for UI5-Elements. Greets, |
Hi All,
First thank you very much for the typescript branch. I am really super excited about the progress made here. I think the overall developments in this direction will be a giantic step for the UI5 development generally. After developing a year with typescript I really don't want to go back - It is fantastic that my day-to-day framework now makes that step too..
Regarding typescript the most "urgent" open point was mentioned in PR #5.
There are however two more open points, which I'd like to address, which might be a big help for application developers. Both can be easily implemented by customers, so are therefore no blockers at all, but imo would be great inside the core product / framework.
I am not sure if that is the right place (probably more the typescript or the openui5 repo?), but still I want to give you short feedback also regarding the sample, as maybe (if this here should be a best practice typescript application) you might add sth. of the examples below inside your code.
Open up JSONModel
Typescript and JSON-Model is a small "no-no" when using the "normal API". Using
setProperty("long/long/1/path/without/typing", some_unknown_value)
inside typescript is very sad.In out project we have build a sub-class of the JSON Model, which:
For that however both "oData" && checkUpdate should be opened and made public (we are working with "any" atm, to workaround that restriction).
Example-Code: State
and Usage inside a controller..
![grafik](https://user-images.githubusercontent.com/19237828/114303004-0b636000-9acc-11eb-8c74-66b77c5d8532.png)
Using that "State" approach you can mostly avoid using formatter by using "getters" instead (ofc not "perfect", as the change detection is not working here, but still nice). Example of a state method:
JSONModel:
Promisification
Using transpiler / babel we can finally use await/async - but the scope of it is somewhat limited without the use of promise based APIs. UI5 still has a lot of places where callback based APIs are published. As ofc breaking changes are not really possible, i'd suggest the creation of some reusable classes build on top of the existing APIs.
I want to give you two short examples of our current project, where we have build promisified versions of the ODataModel handler and the MessageBox method.
Regards,
Timo
The text was updated successfully, but these errors were encountered: