Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-hardcode all colors to allow for dark themes #27

Open
yousefamar opened this issue May 27, 2017 · 2 comments
Open

Un-hardcode all colors to allow for dark themes #27

yousefamar opened this issue May 27, 2017 · 2 comments
Labels

Comments

@yousefamar
Copy link
Contributor

First of all, love this template. I use a pug port at http://yousefamar.com (GitHub). You'll notice I like things dark. I remember there was some talk of themes. Short of that, I think it might be useful to have all the remaining colors that are hardcoded in become variables up top too, to at least be able to tweak for colors for dark themes. I've already done this for my version though I ended up doing my own hardcoding and we've diverged quite a bit. That way, having a dark theme could just be a matter of uncommenting a block of variables on the top (and lightens becoming darkens automatically).

@RyanFitzgerald
Copy link
Owner

Great idea and I like your colour scheme! I'll definitely get this into the next release so there is more flexibility when it comes to actual colour customization, I especially like the idea of being able to easily transition between lighten and darken based on the type of colours you decide to go for.

@jessb321
Copy link

Funnily enough, I too am using pug for my version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants