CI: bump clippy to 1.84 (#550)

Also runs `cargo clippy --fix`

Author: tarcieri

.github/workflows/workspace.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: RustCrypto/actions/cargo-cache@master
       - uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: 1.81.0
+          toolchain: 1.84.0
           components: clippy
       - run: cargo clippy --all -- -D warnings
 

argon2/src/lib.rs

@@ -635,13 +635,13 @@ impl PasswordHasher for Argon2<'_> {
     }
 }
 
-impl<'key> From<Params> for Argon2<'key> {
+impl From<Params> for Argon2<'_> {
     fn from(params: Params) -> Self {
         Self::new(Algorithm::default(), Version::default(), params)
     }
 }
 
-impl<'key> From<&Params> for Argon2<'key> {
+impl From<&Params> for Argon2<'_> {
     fn from(params: &Params) -> Self {
         Self::from(params.clone())
     }

balloon-hash/src/lib.rs

@@ -269,7 +269,7 @@ where
     }
 }
 
-impl<'key, D: Digest + FixedOutputReset> From<Params> for Balloon<'key, D>
+impl<D: Digest + FixedOutputReset> From<Params> for Balloon<'_, D>
 where
     Array<u8, D::OutputSize>: ArrayDecoding,
 {

bcrypt-pbkdf/src/lib.rs

@@ -135,7 +135,7 @@ pub fn bcrypt_pbkdf(
     const STACK_STRIDE: usize = 8;
 
     // Allocate a Vec large enough to hold the output we require.
-    let stride = (output.len() + BHASH_OUTPUT_SIZE - 1) / BHASH_OUTPUT_SIZE;
+    let stride = output.len().div_ceil(BHASH_OUTPUT_SIZE);
 
     let mut vec_buf;
     let mut stack_buf = [0u8; STACK_STRIDE * BHASH_OUTPUT_SIZE];
@@ -172,7 +172,7 @@ pub fn bcrypt_pbkdf_with_memory(
     output: &mut [u8],
     memory: &mut [u8],
 ) -> Result<(), Error> {
-    let stride = (output.len() + BHASH_OUTPUT_SIZE - 1) / BHASH_OUTPUT_SIZE;
+    let stride = output.len().div_ceil(BHASH_OUTPUT_SIZE);
 
     // Validate inputs in same way as OpenSSH implementation
     let passphrase = passphrase.as_ref();