Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1387

Closed
wants to merge 12 commits into from
Closed

Conversation

bytetigers
Copy link

Application whitelist

fix some comments

What do you want to Run On Flux?

Please describe what application(s) do you plan to run.

Is your desired application running somewhere already?

Please provide a POC link to application if it is already running somewhere. (optional)

Is your application open source?

Please provide a source code (optional)

Checklist:

  • Whitelist of application is only modifying repositories.json file
  • repositories.json is still a valid JSON file
  • Only whitelists single docker image organisation (one whitelist at a time, more whitelists, more PRs)
  • No other whitelist has been deleted
  • I agree with ToS https://cdn.runonflux.io/Flux_Terms_of_Service.pdf
  • Application follows ToS - Application is not malicious. Application is not a scam. Application does what is meant to do and does not mislead in any way. Application does not do anything illegal. Application is not a mining application (not even bandwidth mining).
  • In case application receives multiple reports, behaves maliciously, it will be blacklisted and removed from the network.

@bytetigers
Copy link
Author

Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

hyperium/tonic#1869 vechain/thor#817 sushiswap/sushiswap#1606 ReactiveX/RxJava#7749 https://github.com/UMAprotocol/protocol/pull/4778/files https://github.com/zcash/librustzcash/pull/1494/files harmony-one/harmony#4734 #1387 https://github.com/gluwa/creditcoin/pull/1688
 https://github.com/bandprotocol/chain/pull/415
 https://github.com/centrifuge/centrifuge-chain/pull/1963
 bcnmy/biconomy-client-sdk#558

First of all, I am not a robot. I submitted all of them manually. Some of the identification and judgment took a lot of time.

I submitted a method to fix the method name to the https://github.com/vechain/thor/pulls project you maintain. If you think it is worthless, you can close it. Please don't think that others are like you and think it is insignificant.

Don't comment under each PR, which reflects your self-righteousness and poor quality.

As the maintainer of this project said, I don't think there is anything wrong with such changes gluwa/creditcoin#1688

@TheTrunk TheTrunk changed the base branch from master to development August 20, 2024 13:42
Copy link

gitguardian bot commented Aug 20, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8398280 Triggered PGP Private Key bf5252b HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 304dd6f HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 304dd6f HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key bf5252b HomeUI/dist/js/index.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@TheTrunk TheTrunk closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants