-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix some comments #1387
chore: fix some comments #1387
Conversation
Signed-off-by: bytetigers <[email protected]>
Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos. hyperium/tonic#1869 |
First of all, I am not a robot. I submitted all of them manually. Some of the identification and judgment took a lot of time. I submitted a method to fix the method name to the https://github.com/vechain/thor/pulls project you maintain. If you think it is worthless, you can close it. Please don't think that others are like you and think it is insignificant. Don't comment under each PR, which reflects your self-righteousness and poor quality. As the maintainer of this project said, I don't think there is anything wrong with such changes gluwa/creditcoin#1688 |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
8398280 | Triggered | PGP Private Key | bf5252b | HomeUI/dist/js/index.js | View secret |
8398280 | Triggered | PGP Private Key | 304dd6f | HomeUI/dist/js/index.js | View secret |
8398280 | Triggered | PGP Private Key | 304dd6f | HomeUI/dist/js/index.js | View secret |
8398280 | Triggered | PGP Private Key | bf5252b | HomeUI/dist/js/index.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Application whitelist
fix some comments
What do you want to Run On Flux?
Please describe what application(s) do you plan to run.
Is your desired application running somewhere already?
Please provide a POC link to application if it is already running somewhere. (optional)
Is your application open source?
Please provide a source code (optional)
Checklist: