-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse more data #5
Conversation
…:get() into its own small function in (new) util.rs called load_url(); load_url() accepts an optional "subpage" argument so that we can, soon, load additional profile pages
…<ClassInfo> in the value field instead of Option<u32> for just the level (THIS COMMIT DOES NOT COMPILE)
…h_capacity() to make the HashMap
Also just noticed I accidentally included |
Thank you very much for taking an interest in this crate and making a PR for it! In order to test this PR I've made a new test case. To get it into this PR I've made my own PR onto this branch so you can work with it. It uses a dead account to pull information from, so unfortunately it's not able to test out anything new but it can provide a base for seeing how well it scrapes data. The only input I have is that for any new public function I would like there to be doc comments so that the auto-generated docs explain the usage of the method to new people. The ones I see missing are for the following:
Besides that I would like for new information to be added to tests just to make sure that it grabs information correctly. |
Add test for checking attributes
…XP on a class, treat that as None
Just as a heads up, I haven't forgotten about this (nor the other stuff I want to add ;)), I just haven't had time to address these yet |
Alrighty, I think this is good to go @Roughsketch - let me know if it looks like I've missed anything or you want anything changed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Going to merge this and then update the dependencies to their current versions before releasing 0.4.0.
Thanks for the PR!
No problem :) I have more coming once I have time that will check off more of the boxes in #3 |
This updates the lib to parse HP/MP, attributes, and each job's current/max XP. It'll tick a bunch of the boxes in #3.