fix: exclude wildcard from ModelTrait::getFields result

Laravel's default $guarded = ['*'] was being merged directly into
getFields(), leaking '*' into consumers like getOrderableFields.
Now guarded wildcard is filtered out and merged sources are deduped.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: AZabolotnikov

src/Traits/ModelTrait.php

@@ -17,13 +17,15 @@ public static function getFields(): array
         $model = (new static());
 
         $keyName = $model->getKeyName();
-        $guarded = $model->getGuarded();
+        $guarded = array_diff($model->getGuarded(), ['*']);
         $fillable = $model->getFillable();
         $timeStamps = ($model->timestamps) ? ['created_at', 'updated_at'] : [];
 
         array_unshift($fillable, $keyName);
 
-        return array_merge($fillable, $guarded, $timeStamps);
+        $result = array_merge($fillable, $guarded, $timeStamps);
+
+        return array_values(array_unique($result));
     }
 
     public function getAllFieldsWithTable(): array

tests/BaseRequestTest.php

@@ -16,7 +16,7 @@ public function testGetOrderableFields()
     {
         $result = $this->callEncapsulatedMethod(new BaseRequest(), 'getOrderableFields', TestModel::class);
 
-        $expectedResult = 'id,name,json_field,custom_cast_field,castable_field,*,created_at,updated_at';
+        $expectedResult = 'id,name,json_field,custom_cast_field,castable_field,created_at,updated_at';
 
         $this->assertEquals($expectedResult, $result);
     }
@@ -30,7 +30,7 @@ public function testGetOrderableFieldsWithAdditionalFields()
 
         $result = $this->callEncapsulatedMethod(new BaseRequest(), 'getOrderableFields', ...$args);
 
-        $expectedResult = 'id,name,json_field,custom_cast_field,castable_field,*,created_at,updated_at,additional_field_1,additional_field_2';
+        $expectedResult = 'id,name,json_field,custom_cast_field,castable_field,created_at,updated_at,additional_field_1,additional_field_2';
 
         $this->assertEquals($expectedResult, $result);
     }

tests/ModelTraitTest.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace RonasIT\Support\Tests;
+
+use RonasIT\Support\Tests\Support\Mock\Models\TestModel;
+use RonasIT\Support\Tests\Support\Mock\Models\TestModelWithGuardedFields;
+use RonasIT\Support\Tests\Support\Mock\Models\TestModelWithGuardedWildcard;
+use RonasIT\Support\Tests\Support\Mock\Models\TestModelWithoutTimestamps;
+
+class ModelTraitTest extends TestCase
+{
+    public function testGetFieldsDoesNotContainWildcard()
+    {
+        $fields = TestModel::getFields();
+
+        $this->assertNotContains('*', $fields);
+
+        $this->assertEquals([
+            'id',
+            'name',
+            'json_field',
+            'custom_cast_field',
+            'castable_field',
+            'created_at',
+            'updated_at',
+        ], $fields);
+    }
+
+    public function testGetFieldsWithGuardedWildcardOnly()
+    {
+        $fields = TestModelWithGuardedWildcard::getFields();
+
+        $this->assertNotContains('*', $fields);
+
+        $this->assertEquals(['id', 'created_at', 'updated_at'], $fields);
+    }
+
+    public function testGetFieldsWithGuardedFields()
+    {
+        $fields = TestModelWithGuardedFields::getFields();
+
+        $this->assertEquals(['id', 'name', 'secret_field', 'created_at', 'updated_at'], $fields);
+    }
+
+    public function testGetFieldsDoesNotContainDuplicates()
+    {
+        $fields = TestModelWithoutTimestamps::getFields();
+
+        $this->assertEquals(['id', 'name', 'created_at'], $fields);
+    }
+}

tests/support/Mock/Models/TestModelWithGuardedFields.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace RonasIT\Support\Tests\Support\Mock\Models;
+
+use Illuminate\Database\Eloquent\Model;
+use RonasIT\Support\Traits\ModelTrait;
+
+class TestModelWithGuardedFields extends Model
+{
+    use ModelTrait;
+
+    protected $table = 'test_models';
+
+    protected $fillable = [
+        'name',
+    ];
+
+    protected $guarded = [
+        'secret_field',
+    ];
+}

tests/support/Mock/Models/TestModelWithGuardedWildcard.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace RonasIT\Support\Tests\Support\Mock\Models;
+
+use Illuminate\Database\Eloquent\Model;
+use RonasIT\Support\Traits\ModelTrait;
+
+class TestModelWithGuardedWildcard extends Model
+{
+    use ModelTrait;
+
+    protected $table = 'test_models';
+
+    protected $guarded = ['*'];
+}