fix: Removed Py2neo-related code #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#93] Refer to GitHub issue... This commit removed all code references to the Py2neo package, which were previously removed from the project's dependencies. The changes included: - Deleted Python code that imported and referenced Py2neo. - Commented out references to the `Graph` class in `graph/graph.py` as it was based on Py2neo. The decision to comment out instead of deleting was made for future reference purposes. - Autoformatted several Python files that hadn't been previously styled according to the project's style guide. - Removed the Py2neo package from `environment.yml`. The current commit successfully passed the Pytest after modification.
yunchae-kim
added
the
minor
yunchae-kim
deleted the
fix/issue-93/remove-all-code-references-to-py2neo
branch
yunchae-kim
added a commit
that referenced
this pull request
Oct 24, 2023
[#108] Refer to GitHub issue... Changes implemented: - Reverted changes from PR-#95 to address the "class `Graph` not defined" error. - Removed all Py2neo package imports. - Commented out code related to Py2neo, especially the `Neo4jData()` class in `io.py`. - In `graph.py`, replaced usages of `Neo4jData()` within the `Graph` class with a `NotImplementedError`. - Updated comments and docstrings to match these changes. - Autoformatted edited files to match the project's style guide. - Verified the changes: All Pytest checks passed successfully and no errors were encountered when building Sphinx docs using `make html`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#93] Refer to GitHub issue...
This commit removed all code references to the Py2neo package, which were previously removed from the project's dependencies. The changes included:
Graphclass ingraph/graph.pyas it was based on Py2neo. The decision to comment out instead of deleting was made for future reference purposes.Neo4jDataclass ingraph/io.py.environment.yml.The current commit successfully passed the Pytest after modification.