Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve suggestions - Tooltips #474

Closed
variondev opened this issue Oct 31, 2024 · 2 comments
Closed

Improve suggestions - Tooltips #474

variondev opened this issue Oct 31, 2024 · 2 comments

Comments

@variondev
Copy link

variondev commented Oct 31, 2024 •
edited by Rollczi
Loading

Tooltips
@huanmeng-qwq
Copy link
Contributor

Tooltips #461

Rollczi added a commit that referenced this issue Nov 2, 2024
@huanmeng-qwq @Rollczi
GH-474 Suggestion tooltip (#461)
f621def 
* Support tooltip in paper

* ignore relocation, fix TAB_COMPLETION_CLASS

* fix unable to create a Completion correctly

* If the string is empty, there is no tooltip

* Support Fabric, Minestom and Sponge

* .

* Add tests

* Remove Completion

* Update Suggestion.java

* Update tests

* Add tooltipCollector

* fix test

* Update litecommands-unit/src/dev/rollczi/litecommands/unit/AssertSuggest.java

Co-authored-by: Norbert Dejlich <[email protected]>

* catch style

* remove tooltip method, fix assertSuggest, remove tooltipCollector

* tooltip for partial platform arguments

* Remove tooltips from the suggestion result.

* Make tooltip notnull

* Add missing collector for tooltips. Code style fixes.

* Use collector

* Make assertSuggest more simpler

* Use tooltip collector.

* Copy tooltip while appending

* Add preconditions for Suggestion.

* Make Suggestion#from internal.

* Support async suggestions for 1.12-1.15 paper

---------

Co-authored-by: Norbert Dejlich <[email protected]>
@Rollczi Rollczi changed the title Improve suggestions Improve suggestions - Tooltips Nov 2, 2024
@Rollczi Rollczi closed this as completed Nov 2, 2024
@Rollczi
Copy link
Owner

Rollczi commented Nov 2, 2024

#477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rollczi @huanmeng-qwq @variondev