-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fee Percentage Wrong #29
Comments
Hello - I believe when fee percentage is used, it is either divided by 100 or it compares to a value with a similar order of magnitude. |
on line 691, you can see that the calculated fees are multiplied times 100, converting them into percentage. So fee percentage is in percentage, line 573 ----- fee_percentage = 0.1%*3 |
Also the fee percentage will be different if you pay with Binance coin as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Regarding TriArb
TriArbTrader
The fee calculation is incorrect it appears.
line 573 ---- fee_percentage = 0.1*3 #divided by 100
pseudo -> fee_percentage = 10%*3 = 30%
Shouldn't the fee percentage be 0.001 * 3 not 0.1 * 3 ?
The text was updated successfully, but these errors were encountered: