Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic tests #48

Open
Deric-W opened this issue Apr 12, 2023 · 5 comments
Open

Automatic tests #48

Deric-W opened this issue Apr 12, 2023 · 5 comments

Comments

@Deric-W
Copy link
Contributor

Deric-W commented Apr 12, 2023

Hello,
since this project supports two platforms and two Ros2 Distributions I think it would be beneficial to run the tests automatically when pushing to master to prevent some combinations from being left out and decrease the amount of work required to verify contributions.

I thougt about using Github Actions for this purpose, what do you think?

@Deric-W
Copy link
Contributor Author

Deric-W commented May 5, 2023

Iam a bit confused which ROS2 distributions and platforms are supported, the Readme mentions Ubuntu and Windows with galactic and humble while there exists additional utilities for foxy, MacOSX and UWP.
Where these just forgotten or is the Readme wrong?

@pijaro
Copy link
Collaborator

pijaro commented May 8, 2023

Automatic testing is definitely on our roadmap. We primarily wanted to pair it with Ros2ForUnity, but handling Unity appeared to be a problem in CI/CD. Therefore, the delay.

As for the support - we support Galactic/Humble on Ubuntu/Windows. However, we left the foxy and other utilities because they "should" work. We can't guarantee it, and our help can be limited, but it can be run if someone really wants to. I believe we will clean the "leftovers" with the new release.

@Deric-W
Copy link
Contributor Author

Deric-W commented May 12, 2023

Iam currently experimenting on this branch and try to get the Windows setup working.
Can we ignore Unity for this repository since it is mostly independent?

@pijaro
Copy link
Collaborator

pijaro commented May 16, 2023

Yes, definitely, we can ignore the Unity for this repo 👍

@Deric-W
Copy link
Contributor Author

Deric-W commented May 31, 2023

I have problems getting the Workflow to work on Windows since colcon likes to pick the wrong Python version, did you encounter such issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants