Remove package_name from ros_launch arguments

Author: julianadrianheine

bazel_ros2_rules/lib/ament_index.bzl

@@ -60,6 +60,8 @@ def _ament_index_files_impl(ctx):
     for src in ctx.attr.srcs:
         if ctx.attr.subdirectory == "lib":
             exe_file = src.files_to_run.executable
+            if exe_file == None:
+                continue
             symlink_path = paths.join(
                 ctx.attr.prefix,
                 "lib",

bazel_ros2_rules/lib/private/ros_py.bzl

@@ -202,11 +202,6 @@ def ros_launch(
         # runfiles.py to use "this repository" in a way that doesn't require
         # bespoke information.
         workspace_name = None,
-        # Optional ROS 2 package name. When set, an ament_index_executables
-        # target is created from the data= labels, enabling
-        # launch_ros.actions.Node(package=..., executable=...) to find
-        # Bazel-built binaries without a colcon install space.
-        package_name = None,
         **kwargs):
     main = "{}_roslaunch_main.py".format(name)
     launch_respath = _make_respath(launch_file, workspace_name)
@@ -228,11 +223,11 @@ def ros_launch(
         ],
     )
 
-    if package_name:
+    if data:
         index_target = "_{}_ament_index".format(name)
         ament_index_executables(
             name = index_target,
-            package_name = package_name,
+            package_name = native.package_name(),
             srcs = data,
             visibility = ["//visibility:private"],
         )

ros2_example_bazel_installed/ros2_example_apps/BUILD.bazel

@@ -259,10 +259,9 @@ ros_launch(
 )
 
 # Uses launch_ros.actions.Node, the natural ROS 2 pattern, by registering
-# the Bazel-built binaries in a fake ament prefix via package_name=.
+# the Bazel-built binaries in a fake ament prefix.
 ros_launch(
     name = "eg_launch_with_action_node",
-    package_name = "ros2_example_apps",
     data = [
         ":eg_listener",
         ":eg_talker",