Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to better type inference tooling to detect BC breaks in types #143

Open
Ocramius opened this issue Jul 17, 2019 · 1 comment
Open

Comments

@Ocramius
Copy link
Member

As documented in #134, type inference based on documented types is weak.

In practice, we want to detect type variance changes for complex types, such as @var Foo<Bar, Baz>.

We also want to detect changes such as:

function foo() {
-    return 1;
+    return 'foo';
}

These types are currently not inferred (BC check completely skipped), and that is a problem.

I think @psalm could help with this, but need to inspect further.

@Ocramius
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant