Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-rip checked button row disappears when window 835 pixels or taller #1503

Closed
cinnamonbubblegum opened this issue Nov 29, 2019 · 5 comments · Fixed by #1611
Closed

Re-rip checked button row disappears when window 835 pixels or taller #1503

cinnamonbubblegum opened this issue Nov 29, 2019 · 5 comments · Fixed by #1611

Comments

@cinnamonbubblegum
Copy link

  • Ripme version: 1.7.90-alpha

  • Java version: 11.0.5-ea

  • Operating system: Ubuntu 19.10 x86_64

  • Please include any additional information about how to reproduce the problem:

Expected Behavior

Height of the window shouldn't make buttons appear/disappear

Actual Behavior

When height >= 835, the bottom buttons disappear

Here is the window at 834 pixels height
834

And here at 835 pixels.
835

@cinnamonbubblegum
Copy link
Author

Also reproduced on 1.7.90 release

@cyian-1756
Copy link
Collaborator

I can confirm this on Ubuntu 19.04

@madhatr
Copy link

madhatr commented Dec 1, 2019

I can confirm this on Win10 as well.

@Ronan-H
Copy link

Ronan-H commented Jan 8, 2020

Problem is in MainWindow.java:

historyButtonPanel.setPreferredSize(new Dimension(300, 10));

The button row has a preferred height of 10, which must be a mistake. I think that any time the button row "disappears", it's the row getting it's preferred size, which is too small to actually render any of the buttons.

Just removing that line fixes the issue. Is there any particular reason why the preferred size of the row of buttons needs to be hard coded? If that's the case then picking a more appropriate preferred height for the row also fixes the issue.

@cinnamonbubblegum
Copy link
Author

Seems like an easy fix then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants