Problem loading XML documentation on OS X

[tor-stangeland-bouvet]

We have a custom tool that runs as part of our build process that uses Namotion.Reflection to extract the XML documentation. This runs fine on Windows and Linux, but on OS X the XML documentation file is not found.

Looking into the code I have found two bugs that should be handled:

1. If running on OS X, using Assembly.Location folder is not done, only check for NuGet package is done. This is in XmlDocsExtensions.GetPathByOs() (

   Namotion.Reflection/src/Namotion.Reflection/XmlDocsExtensions.cs

   Line 946 in a4354e2

   private static string? GetPathByOs(dynamic? assembly, AssemblyName assemblyName)

   )
2. The Assembly.CodeBase is handled differently on Windows where removing file:/// still results in an absolute path. While on Linux and OS X the first / (slash) is removed so that it becomes a relative address.
   

   Namotion.Reflection/src/Namotion.Reflection/XmlDocsExtensions.cs

   Lines 751 to 765 in a4354e2

   	if (ObjectExtensions.HasProperty(assembly, "CodeBase"))
   	{
   	var codeBase = (string)assembly.CodeBase;
   	if (!string.IsNullOrEmpty(codeBase))
   	{
   	path = DynamicApis.PathCombine(DynamicApis.PathGetDirectoryName(codeBase
   	.Replace("file:///", string.Empty)), assemblyName.Name + ".xml")
   	.Replace("file:\\", string.Empty);
   	if (DynamicApis.FileExists(path))
   	{
   	return path;
   	}
   	}
   	}

[tor-stangeland-bouvet]

Started working on a fix here: https://github.com/tor-stangeland-bouvet/Namotion.Reflection

Need to test a bit more on Linux and OS X before submitting a PR.