Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievements in Core Sets Filter is Not Working #2335

Open
isaacschepp opened this issue Apr 5, 2024 · 1 comment
Open

Achievements in Core Sets Filter is Not Working #2335

isaacschepp opened this issue Apr 5, 2024 · 1 comment
Labels
area/back-end status/blocked This issue implies changes that have unmet requirements

Comments

@isaacschepp
Copy link

Describe the bug

https://retroachievements.org/achievementList.php?s=14&p=3

The achievement in core sets filter is not working on the "Hardest Achievments" page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://retroachievements.org/achievementList.php?s=14&p=2
  2. Click on Achievements in Core Sets
  3. See that achievements from subsets are still included.

Expected behavior
It should filter out achievements in subsets.

Desktop (please complete the following information):

  • OS: Windows 11 Home
  • Browser: Chrome
  • Version: Version 123.0.6312.105 (Official Build) (64-bit)
@wescopeland
Copy link
Member

wescopeland commented Apr 6, 2024

At present time, with some minor nuance, subsets are functionally equivalent to core sets on the site.

We should revisit this issue while building out the new multiset functionality. I'd prefer not to build a workaround into the current system for handling this specific logic until we're closing to multiset being a reality. Right now the only way to check if a set is a subset is by using string comparisons in a game's title. Unfortunately, this disables indexing.

@wescopeland wescopeland added status/blocked This issue implies changes that have unmet requirements area/back-end labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/back-end status/blocked This issue implies changes that have unmet requirements
Projects
None yet
Development

No branches or pull requests

2 participants