Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestones not showing in the correct order #2109

Open
wescopeland opened this issue Dec 15, 2023 Discussed in #2108 · 5 comments
Open

Milestones not showing in the correct order #2109

wescopeland opened this issue Dec 15, 2023 Discussed in #2108 · 5 comments
Assignees
Labels
area/back-end kind/enhancement New feature or request

Comments

@wescopeland
Copy link
Member

Discussed in #2108

Originally posted by slashtangent December 15, 2023
There is a bug with milestones not showing the correct timeline of events. Using mine as an example: https://retroachievements.org/user/SlashTangent/progress It shows that my first beaten game was Halo 2600 on Jan 6 2021 however, I have games beaten before then. In this instance, I think my first beaten game is Pokemon TCG (GBC) on November 13th, 2020.

@wescopeland wescopeland self-assigned this Dec 15, 2023
@wescopeland
Copy link
Member Author

@slashtangent I believe the issue here is once a beaten award "graduates" to a mastery, the milestones section no longer recognizes the game as being beaten. Maybe we should change it so it's no longer doing this - it seems the current behavior is unexpected.

@MSGoodman
Copy link
Contributor

Taking a look at the linked page, it looks like it's displayed in the correct order as per your above comment:
image

Has this been resolved by some other change since this was reported? Or am I misreading this?

@wescopeland
Copy link
Member Author

wescopeland commented Jan 7, 2024

No changes since the issue was reported.

These are the milestones:
Screenshot 2024-01-07 at 11 39 41 AM

Right now they're also following the award "graduation" behavior that the main content on the page follows. Perhaps it shouldn't?

@wescopeland
Copy link
Member Author

A better description of the current (and probably undesirable) behavior:

  • Let's say I beat a game in January 2019. It's my first beaten game.
  • I take a break from RA. I return in 2022 and beat several more games.
  • Next, I master the game that I first beat in January 2019.
  • That first beaten game no longer appears as my first beat. It's now my first mastery. My first beat is the 2nd game I beat when I returned in 2022.

Wherever this ends up, I vaguely remember that Milestones doesn't have great test coverage (this is my fault). We should beef up that coverage as part of this.

@wescopeland wescopeland added kind/enhancement New feature or request and removed where/user-profiles labels May 6, 2024
@wescopeland
Copy link
Member Author

Per #2432, I plan on tackling this once milestones is extracted into its own service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/back-end kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants