Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User List issue #1089

Open
Tsearo opened this issue Aug 13, 2022 · 3 comments
Open

User List issue #1089

Tsearo opened this issue Aug 13, 2022 · 3 comments
Labels
area/back-end kind/bug Something isn't working

Comments

@Tsearo
Copy link
Contributor

Tsearo commented Aug 13, 2022

Only lists hardcore points but achievement count does either, should be updated now after the softcore points change
image

@Krylan
Copy link
Contributor

Krylan commented Dec 20, 2022

@Tsearo To be more specific: what is expected result? "Achievements Earned" should show only hardcore achievements (like on global ranking: https://retroachievements.org/globalRanking.php), or rather points should include softcore value as well?

@Tsearo
Copy link
Contributor Author

Tsearo commented Dec 21, 2022

Currently it shows hardcore points and softcore + hardcore achievements. There are multiple solutions I feel but the main issue is that there is a discrepancy between the data it pulls for points vs achievements earned and they should at least match whether it is combined or just hardcore or split I don't have much preference.

@wescopeland wescopeland added kind/bug Something isn't working area/back-end labels Jul 12, 2023
@MSGoodman
Copy link
Contributor

Is this still relevant? It seems like a pretty straightforward change, regardless of what columns/data to include. My thoughts are:

  1. Minimum Update for Consistency: Right now it's using RAPoints (which looks like it's hardcore points) and achievements_unlocked (which seems to be softcore achievements). Change getUserListByPerms to either use both hardcore values (RAPoints and achievements_unlocked_hardcore) or both softcore values (RASoftcorePoints and achievements_unlocked)
  2. Copy global ranking columns: Feels kind of like it obviates this page, for the most part, but I suppose the sorting is nice?
  3. More exhaustive table: We could have this page be more exhaustive. Could include hardcore points, hardcore achievements, softcore points, softcore achievements, mastered games, join date, and whatever other stuff we'd want. Really just comes down to what this page is actually for and how people use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/back-end kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants