chores: Bump smol version to 2.0 #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix Restioson#220. The changes include removing smol-potat in favor of smol::block_on. However, this commit does not remove smol-timeout as it is heavily used on tests and the crate seems to be unmaintained. Nontheless tests keep working.
|
Hey, thanks for the PR! Really sorry for getting back to this so late, studies have been all-consuming this year. I wonder if we would want to keep smol 1.0 support under a different feature (e.g. smol-1)? |
As long as there is a release with smol-1 support, I wouldn't bother too much :) |
|
That's fair, since I suppose we haven't really made any other changes |
Restioson
reviewed
Nov 8, 2024
|
|
||
| fn main() { | ||
| smol::block_on(run()) | ||
| } |
There was a problem hiding this comment.
Would be happy to merge if we can add back the newline :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #220. The changes include removing smol-potat in favor of smol::block_on. However, this commit does not remove nor update smol-timeout as it is heavily used on tests and the crate seems to be unmaintained. Nonetheless tests keep working.