Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify doesn't work as expected #511

Open
sooyounga opened this issue Feb 17, 2023 · 4 comments
Open

minify doesn't work as expected #511

sooyounga opened this issue Feb 17, 2023 · 4 comments

Comments

@sooyounga
Copy link
Collaborator

while working on #408, we ran into minify issue where mri_convert was not found after minify-ing
we verified mri_convert is working before minify-ing

commands used:

neurodocker generate docker \
    --pkg-manager apt \
    --base-image debian:buster-slim \
    --freesurfer version=7.1.1 \
> freesurfer7.Dockerfile

docker build --tag freesurfer:7.1.1 --file freesurfer7.Dockerfile .
cmd1="mri_convert /home/T1.nii.gz /home/T1.mgz"
cmd2="mri_nu_correct.mni --i /home/T1.mgz --o /home/T1_N3.mgz --n 2"

docker run --rm -itd \
    --name fs \
    --security-opt=seccomp:unconfined \
    -v ${PWD}:/home \
    -v ${PWD}/freesurfer_license.txt:/opt/freesurfer-7.1.1/license.txt \
    -e FS_LICENSE="/opt/freesurfer-7.1.1/license.txt" \
    freesurfer:7.1.1
neurodocker minify \
    --container fs \
    --dir /opt/freesurfer-7.1.1/ \
    "$cmd1" "$cmd2"
@kaczmarj
Copy link
Collaborator

kaczmarj commented Apr 3, 2023

hi @sooyounga - does the file /opt/freesurfer-7.1.1/bin/mri_convert exist in the minified container?

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@Remi-Gau Remi-Gau reopened this Sep 6, 2023
@github-actions github-actions bot removed the stale label Sep 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants