-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync position of adw::TabPages in adw::TabView and FactoryVecDeque #573
Comments
Currently, only the position of the element in the factory container is synced with the position of the widgets and not the other way around. I think I tried to get bidirectional sync working, but I'm not sure why exactly I didn't implement it. I could have another look at the problem, but this might take some time. |
It's better, but is has some bugs for now. The position of tabs are not synced with the factory vector. This issue should be solved in Relm4's side, or we should find a hack to solve it. If it wasn't solved this commit should be reverted before a beta release. Read More: Relm4/Relm4#573
If I have both
adw::TabView
andadw::TabBar
, when I change the position of a tab from theTabBar
, it's position will be changed in theTabView
, but not in theFactoryVecDeque
, so I lose track ofTabPage
s.I think that
FactoryView::factory_update_position
should be implemented foradw::TabView
. Way isn't it implemented? Is there any problem?I tried to use
TabView::connect_page_reordered
to change the position in theFactoryVecDeque
but I wasn't able to. I didn't find a way to reorder elements inFactoryVecDeque
when I just have the aTabPage
and it's new position.Is there any thing that I can do?
The text was updated successfully, but these errors were encountered: