Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding core classes should be avoided #3

Open
xantek-imc opened this issue Sep 3, 2019 · 1 comment
Open

Overriding core classes should be avoided #3

xantek-imc opened this issue Sep 3, 2019 · 1 comment

Comments

@xantek-imc
Copy link

reflektion_magento_2/etc/frontend/di.xml

Line 3 in d64d977

<preference for="Magento\Framework\View\Result\Page" type="Reflektion\Catalogexport\Model\Rewrite\Result\Page" />

I think Reflektion can achieve the goal of early inclusion of script without overriding a core model. If you must go outside of layout XML then maybe Pugin (Interceptor) would be a better approach.
@prashantreflektion
Copy link
Collaborator

Thank you @xantek-imc
We will check this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xantek-imc @prashantreflektion