New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handling and retry capability when making API satellite calls #95

Open

A-Beck opened this issue Jul 26, 2019 · 0 comments

Labels

Collaborator

A-Beck commented Jul 26, 2019

Currently, we do not handle intermittent connection timeouts/connection refused errors as well as we could.

i.e dialogs
https://github.com/RedHatOfficial/miq-RedHat-Satellite6/blob/master/Automate/RedHatConsulting_Satellite6/Integration/Satellite/DynamicDialogs.class/__methods__/get_hostgroups.rb#L87

i.e method
https://github.com/RedHatOfficial/miq-RedHat-Satellite6/blob/master/Automate/RedHatConsulting_Satellite6/Integration/Satellite/Operations/Methods.class/__methods__/register_satellite.rb#L310

In the cases where we do catch possible exceptions, we do not attempt to retry.

It would be great if we caught exceptions and added retry capability to make this code more robust.

A-Beck added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment