Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS domain have to be manually selected even when set in the Satellite Hostgroup #89

Open
sigbjornaib opened this issue Feb 26, 2019 · 5 comments

Comments

@sigbjornaib
Copy link
Contributor

DNS domain have to be manually selected under the "Infrastructure" tab, even when already configured in the Satellite Hostgroup selected in the "Basic" tab.

The DNS domain in the provisioning dialog should be read and set directly from the configured DNS domain in the Satellite Hostgroup, when available in the Satellite Hostgroup.

@itewk
Copy link
Collaborator

itewk commented Feb 26, 2019

@sigbjornaib that would be cool. If you want to do a pull request for that change to have the domain default to what is in the host group we could review it.

The reason we didn't is this code was all made with the use case in mind of simultaneous provisioning to multiple providers. Picking I want 10 VMs and selecting your on prem RHV or VMware provider, and your AWS provider and having CFME automatically distribute the VMs across those providers. And then with the assumption that your domains would be different in different geos but that the satellite host groups wouldn't be. Therefor the reason we don't have this now is our original use case did not define domains in our hostgroups.

But, again, I think it makes sense for domain 1 to default to whatever is set in the houstgroup if the houstgroup has one set.

@sigbjornaib
Copy link
Contributor Author

Ok, that makes sense to me now. Flexibility is always nice. :)

Still, for this customers configuration and I wouldn't be surprised if other shops are similar, the same DNS domain is used for all machine in a single service deployment. Actually the DNS domain name determines if it is in the Lab environment, Acceptance Test environment or in the Production environment. So we do not want the different machines in the same provisioning request from the same Satellite hostgroup to the up in different lifecycle environment DNS domains.

Thank you for considering this enhancement request. :)

@itewk
Copy link
Collaborator

itewk commented Mar 7, 2019

@sigbjornaib if you want to do the needed changes and put in the PR it would be most welcome.

@sigbjornaib
Copy link
Contributor Author

I would love to, however writing Ruby code isn't my strongest feature...

@itewk
Copy link
Collaborator

itewk commented Mar 23, 2019

@sigbjornaib I apologize I am swamped both professionally and personally at the moment.

@curt-matthews or @A-Beck either of you have some bandwidth to read this over and lend a hand to @sigbjornaib who is using this code across the pound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants