Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] title style fixes #2164

Open
3 tasks
marionnegp opened this issue Feb 12, 2025 · 0 comments
Open
3 tasks

[bug] title style fixes #2164

marionnegp opened this issue Feb 12, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@marionnegp
Copy link
Collaborator

Describe the bug

Heading styles from a constructed stylesheet are preventing titles in some card patterns from being consistent with what's in Figma. Some of the computed values end up being correct, but since these titles use --rh-font-family-body-text, the following css uses body-text tokens for the other text properties too. (I think that's what we typically do.)

  • Asset card titles should be using:
font-family: var(--rh-font-family-body-text, RedHatText, 'Red Hat Text', Helvetica, Arial, sans-serif);
font-weight: var(--rh-font-weight-body-text-regular, 400);
font-size: var(--rh-font-size-body-text-md, 1rem);
line-height: var(--rh-line-height-body-text, 1.5);
color: var(--rh-color-text-brand-on-light, #ee0000);
  • Title bar cards should be using
font-family: var(--rh-font-family-body-text, RedHatText, 'Red Hat Text', Helvetica, Arial, sans-serif);
font-weight: var(--rh-font-weight-body-text-regular, 400);
font-size: var(--rh-font-size-body-text-md, 1rem);
line-height: var(--rh-line-height-body-text, 1.5);

Unrelated to the heading style issue in card:

  • Titles in <rh-stat> should be using --rh-font-family-body-text

Screenshots

Image

Steps to reproduce

Check demos for asset cards, title bar cards, and stats.

Expected behaviour

Expected behavior explain the bug description

Element HTML

Operating System (OS)

macOS

Browser

No response

Additional browser or assistive technology info

No response

@marionnegp marionnegp added the bug Something isn't working label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant