Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] <rh-accordion> required attribute aria-level not present on <rh-accordion-header> #2161

Open
adamjohnson opened this issue Feb 10, 2025 · 1 comment
Open

[bug] <rh-accordion> required attribute aria-level not present on <rh-accordion-header> #2161

adamjohnson opened this issue Feb 10, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@adamjohnson
Copy link
Collaborator

adamjohnson commented Feb 10, 2025 •
edited
Loading

Describe the bug

<rh-accordion-header> should have the aria-level attribute but it does not.

Screenshots

Screenshot of rh-accordion-header HTML

Steps to reproduce

  1. Go to the <rh-accordion> demo
  2. Inspect "Item 1" (or whatever the first accordion header is called)
  3. Note the lack of an aria-level attribute on <rh-accordion-header>
  4. Run an axe DevTools test to confirm

Expected behaviour

<rh-accordion-header> should have an aria-level attribute as is required.

Operating System (OS)

macOS

Browser

Microsoft Edge

Additional info

Interestingly, if you disable JS, an aria-level attribute is present.
@adamjohnson adamjohnson added the bug Something isn't working label Feb 10, 2025
@adamjohnson adamjohnson mentioned this issue Feb 10, 2025
Open
1 task
@bennypowers
Copy link
Member

Shouldn't this be handled by element internals?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Red Hat Design System
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamjohnson @bennypowers