Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix Home Page Shows Incorrect Listings #370

Closed
elchris opened this issue Nov 2, 2020 · 2 comments · May be fixed by #378
Closed

[BUG] Fix Home Page Shows Incorrect Listings #370

elchris opened this issue Nov 2, 2020 · 2 comments · May be fixed by #378
Assignees
Labels
bug Something isn't working

Comments

@elchris
Copy link

elchris commented Nov 2, 2020

Describe the bug
https://www.rebuildblackbusiness.com/businesses/ is still making this api call:

https://api.rbb-api.com/api/v1/businesses?page=1&pageSize=11&in-need=true

with the "in-need" in the parameter, when that parameter should be omitted entirely. I think I called this out like a month ago.

essentially it should show you the same results as if you clicked "search" on the form with no filters, which is basically this page:

https://www.rebuildblackbusiness.com/businesses/all

which indeed appears to make the correct API call: https://api.rbb-api.com/api/v1/businesses?page=1&pageSize=11

I believe this bug is from an incomplete implementation of #343

To Reproduce
Steps to reproduce the behavior:

  1. Go to rebuildblackbusiness.com and click "SEE BUSINESSES"
  2. Notice that the first result on the page is "Nari Boo Cosmetics" which was part of our original "In Need" businesses. We should be looking at ALL BUSINESSES on the main page, not just a small subset.
  3. Also notice the pagination is only "12 pages" which further demonstrates the limited set of results

Expected behavior
The first page of businesses should be showing all businesses, as if someone had clicked "search" without selecting any filter or entering any location

@elchris
Copy link
Author

elchris commented Nov 13, 2020

This was fixed as part of #374 -- thank you @Mhmdabed11 !!!!

@elchris elchris closed this as completed Nov 13, 2020
@elchris
Copy link
Author

elchris commented Nov 13, 2020

see above comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants