testing

Author: garoazinha

app/controllers/railsdb/admin/stats_controller.rb

@@ -3,7 +3,6 @@ module Admin
     class StatsController < ApplicationController
       def index
         @stats = Railsdb::Admin::Stats.fetch_avg_durations
-        pp @stats
       end
 
       private

app/views/railsdb/admin/stats/index.html.erb

@@ -17,7 +17,7 @@
         <td class='is-vcentered'><%= stat[:count] %></td>
         <td class='is-vcentered'><%= stat[:avg_duration] %></td>
         <td class='is-vcentered'><%= stat[:sql] %></td>
-        <td class='is-vcentered'><%= stat[:gc_time] %></td>
+        <td class='is-vcentered'><%= stat[:min_duration] %></td>
         <td class='is-vcentered'><%= stat[:max_duration] %></td>
       </tr>
     <% end %>

lib/railsdb/admin/metric_subscriber.rb

@@ -1,10 +1,11 @@
 require 'prettyprint'
 module Railsdb
   module Admin
-    class MetricSubscriber
+    module MetricSubscriber
       def self.add_instrumentation
         ActiveSupport::Notifications.subscribe "sql.active_record" do |*args|
           event = ActiveSupport::Notifications::Event.new(*args)
+          # pp args
 
           event.payload[:alt_name] = event.payload[:name] || name_from_sql(event.payload[:sql])
           unless ["SCHEMA", "TRANSACTION", "ActiveRecord::SchemaMigration Load"].include?(event.payload[:name])

lib/railsdb/admin/stats.rb

@@ -11,18 +11,16 @@ def self.fetch_avg_durations
           avg_duration = durations.sum / durations.size
           first_event = events.first
           payload = first_event.payload
-          gc_time = events.map(&:gc_time).sum
 
           {
             sql: payload[:sql].split(" /*").first,
-            avg_duration: avg_duration,
+            avg_duration: avg_duration.round(2),
             name: payload[:name] || payload[:alt_name],
             count: events.size,
-            max_duration: durations.max,
-            min_duration: durations.min,
-            gc_time: gc_time
+            max_duration: durations.max.round(2),
+            min_duration: durations.min.round(2)
           }
-        end
+        end.sort_by { |event| event[:avg_duration] }
       end
 
       private

test/railsdb/admin/stats_test.rb

@@ -0,0 +1,64 @@
+require "test_helper"
+
+class Railsdb::Admin::StatsTest < ActiveSupport::TestCase
+  setup do
+    Railsdb::Admin::EventStore.instance.clear
+    @stats_klass = Railsdb::Admin::Stats
+  end
+
+  test "returns an array of hashes" do
+    Product.all.to_a
+    catalog = Catalog.create!(title: "Catalog", available: true)
+    Product.create!(name: "Product", code: 100, catalog: catalog)
+
+    stats = @stats_klass.fetch_avg_durations
+    assert_equal(3, stats.size)
+  end
+
+  test "returns one event for product creation" do
+    catalog = Catalog.create!(title: "Catalog", available: true)
+    Product.create!(name: "Product", code: 100, catalog: catalog)
+    Product.create!(name: "Product good", code: 101, catalog: catalog)
+
+    stats = @stats_klass.fetch_avg_durations
+    assert_equal(2, stats.size)
+  end
+
+  test "returns sql query" do
+    Product.all.to_a
+
+    stats = @stats_klass.fetch_avg_durations
+
+    first_event = "SELECT \"products\".* FROM \"products\""
+    assert_equal(first_event, stats.first[:sql])
+  end
+
+  def create_events
+    event = ActiveSupport::Notifications::Event.new("sql.active_record",
+                                                  10.seconds.ago,
+                                                  3.seconds.ago,
+                                                  1,
+                                                  { sql: "SELECT * FROM products" })
+    event_2 = ActiveSupport::Notifications::Event.new("sql.active_record",
+                                                      10.seconds.ago,
+                                                      5.seconds.ago,
+                                                      6,
+                                                      { sql: "SELECT * FROM products" })
+    Railsdb::Admin::EventStore.instance.add_event(event)
+    Railsdb::Admin::EventStore.instance.add_event(event_2)
+  end
+
+  test "calculates avg duration" do
+    create_events
+    stats = @stats_klass.fetch_avg_durations
+
+    assert_equal(6000, stats.first[:avg_duration].to_i)
+  end
+
+  test "counts the amount of query calls" do
+    create_events
+    stats = @stats_klass.fetch_avg_durations
+
+    assert_equal(2, stats.first[:count])
+  end
+end