-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObservableInput<T> should support Thennable<T>, not PromiseLike<T> #7437
Comments
// Define the Thennable interface // Function that takes an ObservableInput // Example usage // Process the observable |
The type on
ObservableInput
is probably too strict.We'll want to support
Thennable<T>
instead, as that's all that is required to convert withfrom
et al.The upside is we can then support more. The downside is if we decide we need to rely on the returned value of the
then
function, It'll require a breaking change.Implementor note: We probably don't want to publicly expose
Thennable
, I'm sure a lot of folks already have that implemented in their codebase. It's been a mistake that we export*
from types, honestly.The text was updated successfully, but these errors were encountered: