Skip to content

rxjs-5-to-6-migrate doesn't seem to handle operator chaining. #55

Open
@richrd

Description

@richrd

I'm having issues with migrating and still have some type errors that the migrate tool didn't fix. It seems to be related to operator chaining.

BEFORE:

return this.api.request(config).map(res => {
  this.translations = JSON.parse(res.translations);
  return res;
}).share();

AFTER:

return this.api.request(config).pipe(
  map(res => {
    this.translations = JSON.parse(res.translations);
    return res;
  }))
  .share();

EXPECTED:

return this.api.request(config).pipe(
  map(res => {
    this.translations = JSON.parse(res.translations);
    return res;
  }), share());

If I understand correctly the share() in this case should be within the pipe call after map separated by a comma (as shown above). Let me know if I'm mistaken!

Here are the some of the remaining rxjs related type errors I'm getting after the migrate:

error TS2339: Property 'takeUntil' does not exist on type 'Observable<any>'.
error TS2339: Property 'debounceTime' does not exist on type 'EventEmitter<any>'.
error TS2339: Property 'first' does not exist on type 'EventEmitter<any>'.
error TS2339: Property 'share' does not exist on type 'Observable<any>'.
error TS2339: Property 'forkJoin' does not exist on type 'typeof Observable'.
error TS2339: Property 'from' does not exist on type 'typeof Observable'.
error TS2339: Property 'flatMap' does not exist on type 'Observable<any>'.
error TS2339: Property 'forkJoin' does not exist on type 'typeof Observable'.
error TS2339: Property 'from' does not exist on type 'typeof Observable'.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions