Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Inaccurate description of scan behavior in introduction #329

Open
jonahbron opened this issue May 23, 2018 · 2 comments
Open

Inaccurate description of scan behavior in introduction #329

jonahbron opened this issue May 23, 2018 · 2 comments

Comments

@jonahbron
Copy link

In the Purity section of the Introduction, the last paragraph describes scan() working "just like reduce for arrays".

https://rxjs-dev.firebaseapp.com/guide/overview#purity

It is similar, but not identical, since scan still emits every cumulative value, while reduce does not. I tried to search through the source code and the language files with which to make a PR, but I can't find where this text lives. Can someone point me in the right direction so I can propose alternate wording?

@shaunlebron
Copy link

The introduction markdown file is in another repo, presumably linked to as a submodule under rxjs-docs/ in this repo:

https://github.com/ReactiveX/rxjs/blob/master/doc/introduction.md#purity

I'm guessing we have to make PRs in that repo instead?

@niklas-wortmann
Copy link
Member

niklas-wortmann commented Jun 25, 2018

Sorry for the confusion on that. We switched to the the rxjs repo. If you need help with that, just ping me. Sorry for the confusion. This repository is just used to transfer the awesome content already made.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants