Tests are failing on a clean clone

[robert-j-webb]

Hey not sure if this is my machine or something (am I using the wrong SDK)? Anyway, here's the steps to reproduce:

$ git clone [email protected]:ReactiveX/rxdart.git
$ cd rxdart
$ flutter pub get
$ flutter test

And the output:

00:05 +364 ~4: /Users/robertwebb/rxdart/test/subject/behavior_subject_test.dart: BehaviorSubject rxdart #477/#500 - a                                    
a
00:05 +367 ~4: /Users/robertwebb/rxdart/test/subject/behavior_subject_test.dart: BehaviorSubject rxdart #477/#500 - b                                    
b
00:05 +459 ~5 -1: /Users/robertwebb/rxdart/test/transformers/start_with_error_test.dart: Rx.startWithError.asBroadcastStream [E]                         
  Expected: should be done
    Actual: <Instance of '_MultiStream<int>'>
     Which: emitted ! Exception
                      dart:async                                          _StreamController.addError
                      package:async/src/result/error.dart 37:10           ErrorResult.addTo
                      package:async/src/stream_queue.dart 956:29          _TransactionRequest.update
                      package:async/src/stream_queue.dart 419:31          StreamQueue._updateRequests
                      package:async/src/stream_queue.dart 506:5           StreamQueue._addResult
                      package:async/src/stream_queue.dart 478:9           StreamQueue._ensureListening.<fn>
                      ===== asynchronous gap ===========================
                      dart:async                                          _MultiStream.listen
                      package:async/src/stream_queue.dart 475:31          StreamQueue._ensureListening
                      package:async/src/stream_queue.dart 124:7           new StreamQueue._
                      package:async/src/stream_queue.dart 118:56          new StreamQueue
                      package:test_api                                    expectLater
                      test/transformers/start_with_error_test.dart 36:11  main.<fn>
                      test/transformers/start_with_error_test.dart 29:47  main.<fn>
                      
                    x Stream closed.
  
  package:test_api                                    expectLater
  test/transformers/start_with_error_test.dart 40:11  main.<fn>
  ===== asynchronous gap ===========================
  dart:async                                          _asyncThenWrapperHelper
  test/transformers/start_with_error_test.dart        main.<fn>
  
00:06 +521 ~5 -2: /Users/robertwebb/rxdart/test/transformers/backpressure/sample_time_test.dart: Rx.sampleTime [E]                                       
  Expected: should do the following in order:
            • emit an event that <1>
            • emit an event that <3>
            • emit an event that <4>
            • be done
    Actual: <Instance of '_ControllerStream<int>'>
     Which: emitted • 2
              which didn't emit an event that <1>
  
  package:test_api                                            expectLater
  test/transformers/backpressure/sample_time_test.dart 14:11  main.<fn>
  test/transformers/backpressure/sample_time_test.dart 11:25  main.<fn>
  
00:07 +555 ~5 -3: /Users/robertwebb/rxdart/test/transformers/backpressure/sample_test.dart: Rx.sample [E]                                                
  Expected: should do the following in order:
            • emit an event that <1>
            • emit an event that <3>
            • emit an event that <4>
            • be done
    Actual: <Instance of '_ControllerStream<int>'>
     Which: emitted • 2
              which didn't emit an event that <1>
  
  package:test_api                                       expectLater
  test/transformers/backpressure/sample_test.dart 18:11  main.<fn>
  test/transformers/backpressure/sample_test.dart 15:21  main.<fn>
  
00:07 +567 ~6 -4: /Users/robertwebb/rxdart/test/transformers/backpressure/buffer_test.dart: Rx.buffer [E]                                                
  Expected: should do the following in order:
            • emit an event that [0, 1]
            • emit an event that [2, 3]
            • be done
    Actual: <Instance of '_ControllerStream<List<int>>'>
     Which: emitted • [0, 1]
                    • [2]
                    • [3]
                    x Stream closed.
              which didn't emit an event that [2, 3] because it emitted an event that at location [1] is [2] which shorter than expected
  
  package:test_api                                       expectLater
  test/transformers/backpressure/buffer_test.dart 18:11  main.<fn>
  test/transformers/backpressure/buffer_test.dart 17:21  main.<fn>
  
00:09 +695 ~6 -5: /Users/robertwebb/rxdart/test/transformers/on_error_resume_test.dart: Rx.onErrorResume still adds data when Stream emits an error: issue/616 [E]
  Bad state: Stream has already been listened to.
  dart:async                                                  _StreamImpl.listen
  package:rxdart/src/transformers/on_error_resume.dart 29:24  _OnErrorResumeStreamSink.onError
  ===== asynchronous gap ===========================
  dart:async                                                  _StreamImpl.listen
  package:rxdart/src/streams/concat.dart 35:26                ConcatStream.listen
  package:rxdart/src/utils/forwarding_stream.dart 81:29       _forward.<fn>.listenToUpstream
  package:rxdart/src/utils/forwarding_stream.dart 109:7       _forward.<fn>
  dart:async                                                  _StreamImpl.listen
  package:async/src/stream_queue.dart 475:31                  StreamQueue._ensureListening
  package:async/src/stream_queue.dart 531:7                   StreamQueue._addRequest
  package:async/src/stream_queue.dart 291:5                   StreamQueue.startTransaction
  package:test_api                                            expect
  test/transformers/on_error_resume_test.dart 173:7           main.<fn>
  
  Expected: should do the following in order:
            • emit an event that <1>
            • emit an event that <-1>
            • emit an event that <2>
            • emit an event that <3>
            • emit an event that <-1>
            • emit an event that <4>
            • be done
    Actual: <Instance of '_ControllerStream<int>'>
     Which: emitted • 1
                    • -1
                    • 2
                    • 3
                    • 4
                    x Stream closed.
              which didn't emit an event that <-1>
  
  package:test_api                                   expect
  test/transformers/on_error_resume_test.dart 173:7  main.<fn>
  
01:28 +1419 ~10 -5: /Users/robertwebb/rxdart/test/rxdart_test.dart: BehaviorSubject rxdart #477/#500 - a                                                 
a
01:28 +1420 ~10 -5: /Users/robertwebb/rxdart/test/rxdart_test.dart: BehaviorSubject rxdart #477/#500 - b                                                 
b
01:30 +1565 ~12 -5: Some tests failed.                                         

And my flutter version:

$ flutter --version                                                                    
Flutter 2.5.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 3595343e20 (6 weeks ago) • 2021-09-30 12:58:18 -0700
Engine • revision 6ac856380f
Tools • Dart 2.14.3

Should the tests be ignored? Or is it possibly something flakey? Thanks :)

[hoc081098]

Related #351 (comment)