You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed that it takes a bit of fiddling to reproduce issues on specific exercises. Would you accept a PR that adds a showLessonByNumber function like:
/** * @param {number} n The lesson number starting from 1 */functionshowLessonByNumber(n){varitem=$(".lesson").get(n-1);if(item){showLesson(item);}else{thrownewError("Exercise "+(n-1)+" could not be found.");}}
Since this would be the third spot we're changing the visibility of a lesson, I'd suggest we extract that function as showLesson:
The text was updated successfully, but these errors were encountered:
morenoh149
changed the title
Any interested in a helper function to show an exercise by number?
Any interest in a helper function to show exercise by number?
Mar 7, 2019
seanpoulter
changed the title
Any interest in a helper function to show exercise by number?
Improvement - Any interest in a helper function to show exercise by number?
Mar 7, 2019
seanpoulter
changed the title
Improvement - Any interest in a helper function to show exercise by number?
Enhancement - Any interest in a helper function to show exercise by number?
Mar 7, 2019
I've noticed that it takes a bit of fiddling to reproduce issues on specific exercises. Would you accept a PR that adds a
showLessonByNumber
function like:Since this would be the third spot we're changing the visibility of a lesson, I'd suggest we extract that function as
showLesson
:We could call this function in these two spots as well:
learnrx/assets/app/show_answers.js
Lines 18 to 21 in 4a1599c
learnrx/assets/app/main.js
Lines 31 to 34 in 4a1599c
The text was updated successfully, but these errors were encountered: