Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It looks like passing all the tests with openjfx 13.0.1 #92

Open
geniejhang opened this issue Feb 24, 2020 · 2 comments
Open

It looks like passing all the tests with openjfx 13.0.1 #92

geniejhang opened this issue Feb 24, 2020 · 2 comments

Comments

@geniejhang
Copy link

Hi,

I tried to change openjfx version from 11 to 13.0.1 and it looks like compiled correctly,
which means, as long as I understand, the library is not using any deprecated API.

Is there any reason not to update it to 2.13.0?

I'm just wondering since my projects are using openjfx 13.0.1.

Thanks for the fantastic library :)

@thomasnield
Copy link
Collaborator

Hi @geniejhang, sorry for slow response. I've been busy with other endeavors this year.

This library needs to finish migration to RxJava 3 as well as OpenJFX so I'm glad to hear it checks out now.

Can you put in a PR or two to target OpenJFX and RxJava2 and/or RxJava3?

@geniejhang
Copy link
Author

Do you have any test in mind except for just changing the version number to the targets?
What I tried is just to use it by changing the version number to 13.0.1 and 14 for OpenJFX.
It also worked with JDK 13.0.2.

For RxJava, I thought by default it's with RxJava2.
I've never tested with RxJava3, though.

If you don't have anything in mind, I can submit pull requests with changing version numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants