Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Update Wiki to the version 2 vocabulary and feature set #6001

Closed
akarnokd opened this issue May 8, 2018 · 8 comments
Closed

2.x: Update Wiki to the version 2 vocabulary and feature set #6001

akarnokd opened this issue May 8, 2018 · 8 comments

Comments

@akarnokd
Copy link
Member

akarnokd commented May 8, 2018

The current Wiki is mostly very old and is written in 0.x - 1.x vocabulary. Since those are end-of-life, they should be replaced by 2.x documentation.

Should we keep the v1 pages?

In a form of non Table-Of-Contents pageset?

How to enable community contribution to the Wiki content?

Editing the wiki is currently restricted, but the larger problem is, how to allow reviews on changes and how to allow the community to contribute small or large?

The wiki itself is under RxJavaWiki.git, but I don't think one can create a PR against it.

My idea is, create a wiki folder in the repo with the .md files and periodically synchronize it with the actual wiki.

Dedicated pages for operator groups?

There are at least 200 operators that could have a dedicated page with example(s), links to JavaDoc & other sources. These could be cross-base types in situations where the same operator is available in the 5-6 base reactive classes. The drawback is that there will be a lot of these. Would we want to spend time on this?

@akarnokd
Copy link
Member Author

akarnokd commented May 8, 2018

PR the wiki possibility: http://www.growingwiththeweb.com/2016/07/enabling-pull-requests-on-github-wikis.html

TLDR; create a separate repo for the wiki files, use scripts to sync back with the main wiki. Now that we have javadoc pushback, this could work.

@vanniktech
Copy link
Collaborator

Personally, I would not keep v1 pages.

My idea is, create a wiki folder in the repo with the .md files and periodically synchronize it with the actual wiki.

That sounds good.

There are at least 200 operators that could have a dedicated page with example(s), links to JavaDoc & other sources. These could be cross-base types in situations where the same operator is available in the 5-6 base reactive classes. The drawback is that there will be a lot of these. Would we want to spend time on this?

Focus on the main ones and maybe mention the other ones. Maybe we can also take most of the bits out of the Javadoc as it's pretty good.

@artem-zinnatullin
Copy link
Contributor

My idea is, create a wiki folder in the repo with the .md files and periodically synchronize it with the actual wiki.

I think we should just store wiki as .md in the repo without syncing it to GitHub wiki and eventually disable GitHub wiki.

Search engines seems to be totally fine indexing markdown files in GitHub repos (I remember having some problems with it in past).

Frankly, I've never understood wiki on GitHub. It's hard to version it with the project, hard to contribute to it, as a result it's always somewhat out of sync and not part of main workflows.

Examples:

  • storio/docs, we link to particular pages from README, you can also place README.md on any sub-folder level so it works like index.html
  • Juno's Engineering Blog is basically markdown files without static website/wiki

Syncing it with GitHub wiki will be very similar to the problem of keeping changelog in sync both in file in the repo and in release section on GitHub, in this particular case I think it makes more sense to just keep wiki in the repo.

@akarnokd
Copy link
Member Author

Posted #6047 . The wiki should be kept online as many may link to it already. After each release, I'll sync up the changes to the docs/ with the wiki

@artem-zinnatullin
Copy link
Contributor

artem-zinnatullin commented Jun 17, 2018 via email

@akarnokd
Copy link
Member Author

I don't think we can do automatic redirect from within the markdown file. I can only disable wiki, not redirect it.

@artem-zinnatullin
Copy link
Contributor

I meant just manual links to corresponding .md files (and maybe headers in them) :)

@akarnokd
Copy link
Member Author

akarnokd commented Aug 3, 2018

Work tracked in #6132.

@akarnokd akarnokd closed this as completed Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants