Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Plan to use Rx5 instead of Rx4 due to breaking changes? #122

Open
tihuan opened this issue Jan 21, 2016 · 13 comments
Open

Plan to use Rx5 instead of Rx4 due to breaking changes? #122

tihuan opened this issue Jan 21, 2016 · 13 comments

Comments

@tihuan
Copy link

tihuan commented Jan 21, 2016

Since Rx5 introduces some breaking changes (link), I was wondering if rx.angular.js will eventually move to Rx5 too.

For example, rx.Observable.replay() is now rx.Observable.publishReplay() in Rx5.

P.S. I'm using rx.angular.js in an ng1.4.8 app :)

Thanks a lot!

@nmn
Copy link

nmn commented Jan 21, 2016

I know this is frowned upon, but +1.

@tihuan
Copy link
Author

tihuan commented Jan 22, 2016

Hey @nmn! I'm still very new to RxJS, so could you elaborate on why this is frowned upon :)? Thanks a lot!

@nmn
Copy link

nmn commented Jan 22, 2016

@tihuan I was talking about the "+1" comments on github.

@tihuan
Copy link
Author

tihuan commented Jan 22, 2016

@nmn Ahaha, I see! I didn't know that's a thing! TIL 🎅

@samal-rasmussen
Copy link

There are actually a bunch of api changes between rx 4 and 5 now: https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md

@awk
Copy link

awk commented Jun 1, 2016

I just created #146 which contains the changes to make rx.angular.js work with RxJS 5 (beta 8 - but I expect the changes will continue to work future betas as RxJS 5 closes on RC the incompatible changes should be fewer)

@tihuan
Copy link
Author

tihuan commented Jun 1, 2016

Woohoo! Thanks for the fabulous work 💯 !

@samal-rasmussen
Copy link

You the man @awk!

@mickdelaney
Copy link

Is this still on the cards ?

@mattbrunetti
Copy link

@mickdelaney I hope so!

@trojanc
Copy link

trojanc commented Sep 1, 2017

I need this too please!

@mattbrunetti
Copy link

Rx5 with Angular 1 ?

note: There's some discussion on this issue in the PR #146

@trojanc
Copy link

trojanc commented Sep 1, 2017

I saw that one, should have paid more attention to it, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants