Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better match base::order(method=) and decreasing= #6655

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

Closes #4456

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (a599557) to head (63fce19).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6655   +/-   ##
=======================================
  Coverage   98.61%   98.62%           
=======================================
  Files          79       79           
  Lines       14559    14567    +8     
=======================================
+ Hits        14358    14366    +8     
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 11, 2024

Comparison Plot

Generated via commit 63fce19

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 37 seconds
Installing different package versions 7 minutes and 30 seconds
Running and plotting the test cases 2 minutes and 14 seconds

@MichaelChirico
Copy link
Member Author

Somehow I'd missed #4458. This PR is narrower, so I suggest merging it independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

order optimization does not recognize all order args properly
1 participant