Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order optimization does not recognize all order args properly #4456

Open
jangorecki opened this issue May 17, 2020 · 0 comments · May be fixed by #6655 or #4458
Open

order optimization does not recognize all order args properly #4456

jangorecki opened this issue May 17, 2020 · 0 comments · May be fixed by #6655 or #4458
Assignees
Labels
Milestone

Comments

@jangorecki
Copy link
Member

jangorecki commented May 17, 2020

current devel

  • rather uncommon case, a non missing method argument
data.table(x=2:1)[base::order(x, method="auto")]
#   x
#1: 1
#2: 2
data.table(x=2:1)[order(x, method="auto")]
#Error: Column 2 is length 1 which differs from length of column 1 (2)
  • length 1+ decreasing argument
data.table(x=2:1, y=2L)[order(x, y, decreasing=c(FALSE,FALSE))]
#Error: isTRUEorFALSE(decreasing) is not TRUE
d = data.table(x=3:1, y=c(2L,1L,3L), z=1:3)
with(d, order(x, y, decreasing=c(FALSE,FALSE)))
#[1] 3 2 1
d[with(d, order(x, y, decreasing=c(FALSE,FALSE)))] ## order is masked with forder inside outer `d` thus has to be compatible
#Error: isTRUEorFALSE(decreasing) is not TRUE
d[with(d, base::order(x, y, decreasing=c(FALSE,FALSE)))]
#   x y z
#1: 1 3 3
#2: 2 1 2
#3: 3 2 1
@jangorecki jangorecki self-assigned this May 17, 2020
@jangorecki jangorecki changed the title order optimization does recognize all order args properly order optimization does not recognize all order args properly May 18, 2020
@jangorecki jangorecki added the bug label May 18, 2020
@jangorecki jangorecki added this to the 1.13.5 milestone Dec 8, 2020
@jangorecki jangorecki modified the milestones: 1.14.3, 1.14.5 Jul 19, 2022
@jangorecki jangorecki modified the milestones: 1.14.11, 1.15.1 Oct 29, 2023
@MichaelChirico MichaelChirico modified the milestones: 1.16.0, 1.17.0 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment