Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PKG_CXXFLAGS = CXX11STD from Makevars #203

Open
mpadge opened this issue Jun 2, 2023 · 3 comments
Open

Remove PKG_CXXFLAGS = CXX11STD from Makevars #203

mpadge opened this issue Jun 2, 2023 · 3 comments

Comments

@mpadge
Copy link

mpadge commented Jun 2, 2023

CRAN will now insist on that being removed anyway, as confirmed yesterday in email from UL which explained that their check is now just grep -r CXX11, so this package will fail in current form.

@kevinushey
Copy link
Contributor

Okay, I'll wait until we receive that communication from CRAN then?

@eddelbuettel
Copy link
Member

FWIW I sort-of did it "rolling" in all my repos. It is a bit of a mixed bag: I have a few where I have set C++14 (because of Boost libraries or alike) which leads to a nag, as does setting C++17. But they clearly no longer want us to set C++11 unless required so just removing worked for me. So my $0.02 would be to remove prior to next upload.

@mpadge
Copy link
Author

mpadge commented Jun 3, 2023

But carefully. I discovered this trying to debug another pkg. With no STD, most systems seem to currently default to 17, and that has some breaking changes in precompiled bits/std headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants