add more tests

Author: Razeeman

app/src/androidTest/java/com/example/util/simpletimetracker/ComplexRulesTest.kt

@@ -618,6 +618,52 @@ class ComplexRulesTest : BaseUiTest() {
         checkRunningRecordWithTag(typeName, tagName, tagValueText)
     }
 
+    @Test
+    fun assignTagValueOnStart() {
+        val typeName = "typeName"
+        val tagName = "onStartTag"
+
+        // Add data
+        runBlocking { prefsInteractor.setAllowMultitasking(false) }
+        testUtils.addActivity(typeName)
+        testUtils.addRecordTag(
+            tagName = tagName,
+            typeName = typeName,
+            hasTagValue = true,
+        )
+
+        // Create rule
+        NavUtils.openSettingsScreen()
+        NavUtils.openSettingsAdditional()
+        NavUtils.openComplexRules()
+        clickOnViewWithText(R.string.running_records_add_type)
+        clickOnViewWithText(R.string.change_complex_rule_choose_action)
+        clickOnViewWithText(R.string.change_complex_action_assign_tag)
+        clickOnViewWithText(tagName)
+        clickOnViewWithText(R.string.change_complex_tag_value_set_later)
+        clickOnViewWithId(dialogsR.id.btnTypesSelectionSave)
+        clickOnViewWithText(R.string.change_complex_starting_activity)
+        clickOnViewWithText(typeName)
+        clickOnViewWithText(R.string.change_activity_filter_save)
+
+        // Check rule
+        val onStartLabel = getString(R.string.change_complex_tag_value_set_later)
+        val expectedTagName = "$tagName ($onStartLabel)"
+        checkViewIsDisplayed(
+            allOf(
+                withId(complexRulesR.id.containerComplexRuleItem),
+                hasDescendant(withText(expectedTagName)),
+            ),
+        )
+        pressBack()
+
+        // Check tag value selection
+        NavUtils.openRunningRecordsScreen()
+        clickOnViewWithText(typeName)
+        checkViewIsDisplayed(withId(dialogsR.id.tvRecordTagValueSelection))
+        checkViewIsDisplayed(withId(dialogsR.id.btnRecordTagSelectionSave))
+    }
+
     @Test
     fun archiveAndRemoveData() {
         val typeName1 = "typeName1"

features/feature_tag_selection/src/main/java/com/example/util/simpletimetracker/feature_tag_selection/viewModel/RecordTagSelectionViewModel.kt

@@ -32,6 +32,25 @@ import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+// No tag selection dialog:
+// - start right away with preselected tags
+// Tag selection dialog:
+// - show preselected
+// - can deselect preselected
+// - multi choice
+// - value selection is added to preselected tags
+// - value selection is queued
+// Close after one (no preselected):
+// - close after one selected
+// - no multi choice
+// - value selection queue is not possible because they are added to preselected
+// Close after one (have preselected):
+// - close after one not working (?)
+// - show preselected (?)
+// - can deselect preselected (?)
+// - multi choice is forced
+// - value selection is added to preselected tags
+// - value selection is queued (?)
 @HiltViewModel
 class RecordTagSelectionViewModel @Inject constructor(
     private val router: Router,
@@ -146,14 +165,6 @@ class RecordTagSelectionViewModel @Inject constructor(
     }
 
     private suspend fun saveClicked() {
-        val hasRequiredTagValueSelectionPending = extra.requiredValueSelectionTagIds
-            .any(::isRequiredTagValueSelectionMissingValue)
-
-        if (hasRequiredTagValueSelectionPending) {
-            updateViewData()
-            startRequiredTagValueSelectionIfNeeded()
-            return
-        }
         addRunningRecordMediator.startTimer(
             typeId = extra.typeId,
             tags = newTags,

wear/src/main/java/com/example/util/simpletimetracker/features/tagsSelection/viewModel/TagsViewModel.kt

@@ -172,14 +172,6 @@ class TagsViewModel @Inject constructor(
     ) {
         val activityId = this@TagsViewModel.activityId ?: return
 
-        val hasRequiredTagValueSelectionPending = requiredValueSelectionTagIds
-            .any(::isRequiredTagValueSelectionMissingValue)
-
-        if (hasRequiredTagValueSelectionPending) {
-            startRequiredTagValueSelectionIfNeeded()
-            return
-        }
-
         _state.value = mapState(loadingState)
 
         val result = startActivityMediator.start(