Change how Reveal works on macOS

Author: Ravbug

source/AppleUtilities.h

@@ -1,5 +1,6 @@
 #pragma once
 #include <cstdint>
+#include <filesystem>
 
 void getCFBundleVersionFromPlist(const char* path, char* outbuf, uint8_t outbuf_size);
 
@@ -9,3 +10,5 @@ enum architecture{
     arm64 = 1 << 2,
 };
 int getArchitectureFromBundle(const char* path);
+
+void RevealFile(const std::filesystem::path& p);

source/AppleUtilities.mm

@@ -29,3 +29,9 @@ int getArchitectureFromBundle(const char* path){
     }
     return archmask;
 }
+
+void RevealFile(const std::filesystem::path& p){
+    const auto str = p.string();
+    auto urlstr = [NSString stringWithUTF8String:str.c_str()];
+    [[NSWorkspace sharedWorkspace] selectFile:urlstr inFileViewerRootedAtPath:@""];
+}

source/globals.cpp

@@ -2,6 +2,9 @@
 #include <fmt/format.h>
 #include <wx/listctrl.h>
 #include <wx/msgdlg.h>
+#if __APPLE__
+#include "AppleUtilities.h"
+#endif
 
 void launch_process(const std::string& command, int flags) {
 #if defined __APPLE__ || defined __linux__
@@ -19,9 +22,9 @@ void launch_process(const std::string& command, int flags) {
 
 void reveal_in_explorer(const std::filesystem::path& path) {
 #if defined __APPLE__
-	std::string command = "open \"" + path.string() + "\"";
-
-#elif defined __linux__
+    RevealFile(path);
+#else
+#if defined __linux__
 	std::string command = "xdg-open \"" + path.string() + "\"";
 
 #elif defined _WIN32
@@ -34,7 +37,7 @@ void reveal_in_explorer(const std::filesystem::path& path) {
 	else {
 		wxMessageBox("The project at " + path.string() + " could not be found.", "Cannot Reveal Project", wxOK | wxICON_ERROR);
 	}
-
+#endif
 }
 
 long wxListCtrl_get_selected(wxListCtrl* listCtrl) {
@@ -78,4 +81,4 @@ void dpi_scale(wxWindow* window){
 	float minw = window->GetMinWidth() * fac;
 	//set the minimum size
 	window->SetSizeHints(wxSize(minw, minh));
-}
+}

source/interface_derived.cpp

@@ -622,7 +622,6 @@ void MainFrameDerived::LoadEditorVersions(){
                 if (!filesystem::exists(infopath)){
                     // maybe this was a direct install
                     infopath = entry / "Contents" / "Info.plist";
-                    basedir = entry;
                 }
                 if (filesystem::exists(infopath) && infopath.string().find("Unity.app") != std::string::npos){
                     // read the file and look for CFBundleVersion