Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing nullability annotation when using the addConcreteSettersForOptional setting #203

Open
zoehneto opened this issue Mar 13, 2025 · 0 comments

Comments

@zoehneto
Copy link

When using record-builder with nullaway, the record-builder approach of keeping field annotations works nicely for nullable fields. In our code base, we often use fields wrapped with Optional instead of nullable fields though, which of course don't have a @Nullable annotation. This causes issues when enabling the option addConcreteSettersForOptional for nullable convenience setters, as those don't have a @Nullable annotation either (which nullaway then complains about). It would be great if we could provide the nullability annotation to use for such cases via the config and then have it on the generated setters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant