Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic for Knack data load errors #3

Open
jillh510 opened this issue Apr 11, 2018 · 3 comments
Open

Retry logic for Knack data load errors #3

jillh510 opened this issue Apr 11, 2018 · 3 comments

Comments

@jillh510
Copy link
Contributor

Have a way to retry data upload to Knack in case of errors

@tkell
Copy link
Contributor

tkell commented Apr 18, 2018

We probably want to log and not retry 4xx errors, and retry 5xx errors with some backoff?

Or do a very simple thing where we try everything twice, and then give up – much less good, but much easier to make.

@jillh510
Copy link
Contributor Author

ActBlue will retry if they don't get a 2xx back from us, so I'm good with logging the failure and then returning an error code to ActBlue.

@tkell tkell mentioned this issue Apr 20, 2018
@tkell
Copy link
Contributor

tkell commented Apr 26, 2018

Closed (for now) with #23 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants